-
Notifications
You must be signed in to change notification settings - Fork 307
Estimate Text Layout using an OffscreenCanvas #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
243a1e6 to
52ce834
Compare
AaronErhardt
commented
Dec 29, 2024
Sounds reasonable to me, but I'm not proficient enough to tell which approach is preferable. In the end, both solution seem like a hack to me, and the question is which hack has the better trade-offs. I'd like to hear another opinion on this matter, but unfortunately I'm the only somewhat active maintainer currently.
jwagner
commented
Dec 30, 2024
Thanks a lot for getting back to me and keeping the project afloat @AaronErhardt.
If browser compatibility is the main concern I could also just add a fallback to a regular (non-offscreen) canvas. That way there is (essentially) only one code path and the dom hackery can go. Canvas is supported in practically every browser that supports wasm.
Uh oh!
There was an error while loading. Please reload this page.
I tried to use plotters in a web worker and ran into a panic in estimate_layout. The reason is fairly obvious, there is no window or document inside of a worker context.
To get plotters to work inside of a web worker I hacked up some code to measure the text size using an OffscreenCanvas.
There are some benefits and drawbacks to this.
I think it should be more resilient than creating a span in the dom and measuring offsetWidth/Height because it is not affected by CSS.
It should be more performant than adding a dom node and measuring the offset properties which cause layout reflows. This is just an educated guess. Didn't benchmark it - takes this claim with a pinch of salt.
I think the main drawback is compatibility. While it is considered to be baseline now, browser support isn't ideal.
There are several ways I see forward. This approach could be used as a fallback when window isn't available or visa versa.
I think it's also an option to just fall back to a really crude approximation along the lines of height = size, width = size * text.len().
Anyway would be glad to get some feedback on this from the maintainers.