-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: Handle arrays in BooleanValidator #5464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearer IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With your change, I removed the if/else block. Clearer indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure whether this call to to_scalar_or_list() is necessary, but I don't think it will hurt.
@emilykl
emilykl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Uh oh!
There was an error while loading. Please reload this page.
Description
Update
BooleanValidatorto handle arrays of values.Addresses half of #5463. The other half is addressed by #5465.
Changes
BooleanValidatorTesting
ValueErroris raised