Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

include nbformat as a plotly[express] dependency #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afeld wants to merge 1 commit into plotly:main
base: main
Choose a base branch
Loading
from afeld:patch-4

Conversation

@afeld
Copy link
Contributor

@afeld afeld commented Oct 16, 2025
edited
Loading

Required for MimeType rendering. Closes #4512.

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • (削除) I have added tests or modified existing tests. (削除ここまで)
  • (削除) For a new feature, I have added documentation examples (please see the doc checklist as well). (削除ここまで)
  • I have added a CHANGELOG entry if changing anything substantial.
  • (削除) For a new feature or a change in behavior, I have updated the relevant docstrings in the code. (削除ここまで)

@gvwilson gvwilson added P2 considered for next cycle community community contribution fix fixes something broken dependencies Pull requests that update a dependency file labels Oct 28, 2025
Copy link
Contributor Author

afeld commented Oct 28, 2025
edited
Loading

Hmm, the remaining build error doesn't sense to me... Doesn't seem to be happening on main, but at a glance, I don't get why this change would have caused it. Any suggestions?

Copy link
Contributor

emilykl commented Nov 17, 2025

@afeld AFAIK nbformat is only required when working with Jupyter notebooks, is there a scenario you've encountered where you require nbformat when working outside Jupyter?

In general we try to keep Plotly Express dependencies pretty minimal and only require packages which are needed in all scenarios.

Would be open to maybe adding a [jupyter] extra or something along those lines though.

Copy link
Contributor Author

afeld commented Nov 18, 2025

nbformat is only required when working with Jupyter notebooks ...

Sure. Do you have a sense of how many Plotly Express users are doing so in Jupyter vs. not?

is there a scenario you've encountered where you require nbformat when working outside Jupyter?

No, I exclusively(?) use Plotly with Jupyter, with build tools like nbconvert and Jupyter Book.

In general we try to keep Plotly Express dependencies pretty minimal and only require packages which are needed in all scenarios.

The impression I got was that plotly contains the bare minimum, while plotly[express] was the "batteries included" / "give me what I need to make charts quickly" option. (Re-reading the Getting Started, realizing that is not what it says.)

Would be open to maybe adding a [jupyter] extra or something along those lines though.

That makes sense to me!

pip install plotly[express,jupyter]

would still be easy for users. I'll update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marthacryan marthacryan Awaiting requested review from marthacryan

At least 1 approving review is required to merge this pull request.

Labels

community community contribution dependencies Pull requests that update a dependency file fix fixes something broken P2 considered for next cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueError: Mime type rendering requires nbformat>=4.2.0 but it is not installed

AltStyle によって変換されたページ (->オリジナル) /