Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

mpl_to_plotly: map enumerated tick labels to Plotly tickvals/ticktext #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willtryagain wants to merge 1 commit into plotly:main
base: main
Choose a base branch
Loading
from willtryagain:feat/mpl-enumerated-ticks

Conversation

@willtryagain
Copy link

@willtryagain willtryagain commented Sep 18, 2025 •
edited
Loading

Hi,
This fixes #5059 preserving axis labels while converting matplotlib plots.

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code

.

@willtryagain willtryagain changed the title (削除) matplotlib tick labels add (削除ここまで) (追記) matplotllib: map enumerated tick labels to Plotly tickvals/ticktext (追記ここまで) Sep 18, 2025
@willtryagain willtryagain changed the title (削除) matplotllib: map enumerated tick labels to Plotly tickvals/ticktext (削除ここまで) (追記) mpl_to_plotly: map enumerated tick labels to Plotly tickvals/ticktext (追記ここまで) Sep 18, 2025
@gvwilson gvwilson added P2 considered for next cycle community community contribution fix fixes something broken labels Sep 23, 2025
Copy link
Contributor

thanks @willtryagain - I'll try to find someone to review this in the next work cycle.
willtryagain reacted with heart emoji

Copy link
Author

Hi @emilykl ,

This change maps enumerated tick labels to Plotly tickvals/ticktext in mpltools.prep_ticks. I realize it could be viewed as risky if applied too broadly (e.g., forcing array-mode on numeric axes). I only tested locally on a simple script.
Would using a more tighter check and adding tests make it easier to review? Let me know if you have any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

community community contribution fix fixes something broken P2 considered for next cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mpl_to_plotly does not preserve axis labels (bar plots are useless)

AltStyle によって変換されたページ (->オリジナル) /