Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Small fix to Histogram2dContour setup in plotly express #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmjw wants to merge 2 commits into plotly:main
base: main
Choose a base branch
Loading
from gmjw:fix-histogram-contour-construction

Conversation

@gmjw
Copy link
Contributor

@gmjw gmjw commented Sep 5, 2025 •
edited
Loading

As per the docs, if z is passed in with no histfunc, it should be set to 'sum':

image

I think this corrects the intended behaviour and puts Histogram2dContour more in line with Histogram2d.

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@gmjw gmjw changed the title (削除) fix (削除ここまで) (追記) Small fix to Histogram2dContour setup in plotly express (追記ここまで) Sep 5, 2025
Copy link
Contributor Author

gmjw commented Sep 5, 2025

If a more experienced contributor takes a look at this - I can't understand why the Circle CI build has failed, the error message doesn't indicate anything clearly - any advice appreciated.

@gvwilson gvwilson self-assigned this Sep 9, 2025
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Sep 9, 2025
Copy link
Contributor

gvwilson commented Sep 9, 2025

thanks @gmjw - much appreciated. the broken Circle CI job isn't your fault - we're working on it...

Copy link
Contributor

emilykl commented Oct 1, 2025

@gmjw This looks great, thanks for the fix. The broken CI job has been fixed on main; it should pass if you merge main into this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gvwilson gvwilson gvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Labels

community community contribution fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /