Fix stacked area hide show bug #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

emilykl wants to merge 2 commits into master

from fix-stacked-area-hide-show-bug

Open

Fix stacked area hide show bug #7668

emilykl wants to merge 2 commits into master from fix-stacked-area-hide-show-bug

+48 −3

Conversation

@emilykl

Copy link

Contributor

@emilykl emilykl commented Dec 8, 2025 •

edited

Loading

Closes #7660

Fixes issue where some traces in stacked area charts were not rendering their fill correctly after certain sequences of hide/show operations in the legend.

Steps to test

Reproduce existing issue

Go to this Codepen (from the docs)
Follow the exact reproduction steps described in 7660:

Double-click "trace 1" to show "trace 1" only

Click "trace 1" again

Now plot is empty

Double click any trace to show all traces again

The orange trace should be missing a fill. This is the bug.

Screenshot 2025年12月08日 at 5 47 23 PM

Confirm that this PR fixes the issue

In the Codepen, replace the plotly.js script src with the build for this branch from the CI: https://output.circle-artifacts.com/output/job/c4caeb45-0a0b-4e23-97b6-ebb26b8561c8/artifacts/0/dist/plotly.js
Repeat the steps under (2) above
All trace fills should render normally.

Screenshot 2025年12月08日 at 5 49 23 PM

@emilykl emilykl marked this pull request as ready for review

December 8, 2025 22:59

@emilykl emilykl requested a review from camdecoster

December 8, 2025 23:00

@emilykl emilykl assigned camdecoster

Dec 8, 2025

camdecoster

camdecoster approved these changes

Dec 9, 2025

View reviewed changes

src/traces/scatter/plot.js Outdated

Comment on lines 86 to 93

// Clear any existing fill element references to ensure clean state

// This prevents stale references when fill configuration changes

trace._ownFill = null;

trace._nextFill = null;

var fillData = [];

if(trace._ownfill) fillData.push('_ownFill');

if(trace._nexttrace) fillData.push('_nextFill');

Copy link

Contributor

@camdecoster camdecoster Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're making _ownFill and _nextFill null, the if checks will always fail. So, let's delete them.

Suggested change

// Clear any existing fill element references to ensure clean state

// This prevents stale references when fill configuration changes

trace._ownFill = null;

trace._nextFill = null;

var fillData = [];

if(trace._ownfill) fillData.push('_ownFill');

if(trace._nexttrace) fillData.push('_nextFill');

// Clear any existing fill element references to ensure clean state

// This prevents stale references when fill configuration changes

trace._ownFill = null;

trace._nextFill = null;

var fillData = [];

Copy link

Contributor Author

@emilykl emilykl Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camdecoster Tragically, _ownFill and _ownfill, as well as _nextFill and _nexttrace, are separate variables. 🙃

Copy link

Contributor

@camdecoster camdecoster Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fair enough. I have words about this, but I won't include them here publicly.

emilykl added 2 commits

December 9, 2025 17:48

@emilykl


 fix issue where some scatter traces would lose fill after series of h...

13d013d

...ide/show operations in legend

@emilykl


 add jasmine test

44bc554

@emilykl emilykl force-pushed the fix-stacked-area-hide-show-bug branch from bcd7e49 to 44bc554 Compare

December 9, 2025 22:48

@ndrezn ndrezn assigned emilykl and unassigned camdecoster

Dec 10, 2025

Labels

None yet

3 participants

@emilykl @camdecoster

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix stacked area hide show bug #7668

Are you sure you want to change the base?

Fix stacked area hide show bug #7668

Conversation

@emilykl emilykl commented Dec 8, 2025 •

edited

Loading

Uh oh!

Steps to test

Reproduce existing issue

Confirm that this PR fixes the issue

Uh oh!

@camdecoster camdecoster Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

@emilykl emilykl Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

@camdecoster camdecoster Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Fix stacked area hide show bug #7668

Are you sure you want to change the base?

Fix stacked area hide show bug #7668

Conversation

@emilykl emilykl commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Reproduce existing issue

Confirm that this PR fixes the issue

Uh oh!

@camdecoster camdecoster Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

@emilykl emilykl Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

@camdecoster camdecoster Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@emilykl emilykl commented Dec 8, 2025 •

edited

Loading