Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Switch color processing library #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
camdecoster wants to merge 19 commits into master
base: master
Choose a base branch
Loading
from cam/7523/switch-color-library

Conversation

@camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Aug 26, 2025 •
edited
Loading

Description

Switch color processing library from TinyColor to color.

Closes #7523.

Changes

  • Change color processing library
    • hsv color strings are no longer permitted
    • Decimal fraction values of rgb strings are no longer permitted. This is a regression, but it's a shortcoming of the library and I'm working on getting it updated.
    • CSS named colors must be lowercase. For example, one must use 'blue' instead of 'Blue'. This is a regression, but it's a shortcoming of the library and I'm working on getting it updated.
  • Update/refactor method calls for dealing with colors
  • Update tests per library change

Testing

  • TBA

Notes

  • The new library allows for use of modern CSS color syntax

TODO

  • Add draftlog
  • Update attribute info about color syntax

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Aug 28, 2025
Copy link
Contributor Author

I created a couple of PRs (#78 and #81) in a dependency used by color that will add some new features for parsing color strings that would bring it closer to parity with TinyColor. The maintainer recently merged one of these and will (hopefully) be merging the other soon. Once he publishes a new release, I'll be able to use it in plotly.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update color processing library to handle modern CSS color syntax

AltStyle によって変換されたページ (->オリジナル) /