Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

New CodeQL codemod for mitigating Regex DoS #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrecsilva wants to merge 4 commits into main
base: main
Choose a base branch
Loading
from ISS-2495/codeql-regex-dos

Conversation

@andrecsilva
Copy link
Contributor

@andrecsilva andrecsilva commented Dec 10, 2024
edited
Loading

\close #work

@andrecsilva andrecsilva marked this pull request as ready for review December 10, 2024 10:24
Copy link
Contributor

@nahsra nahsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a complicated change that will be repeated many times in the codebase. Is there any chance we can get a function like this in the codebase, or add it to the java security toolkit?

If it’s something that must be delivered inline, we should have unit tests that test the code we insert to make sure it’s doing what we think it’s doing.

Copy link

pixeebot[bot] reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nahsra nahsra nahsra requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /