Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add PHP History Timeline #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkurzeja wants to merge 14 commits into php:master
base: master
Choose a base branch
Loading
from accesto:master
Open

Add PHP History Timeline #1284

mkurzeja wants to merge 14 commits into php:master from accesto:master

Conversation

@mkurzeja
Copy link

@mkurzeja mkurzeja commented Jun 23, 2025

Initial implementation of #1265

This adds two main changes:

  1. New view of PHP History Timeline as a separate page. Events are loaded from a .json file

image

https://drop.accesto.com/v/f0cATp

  1. Adds link to the new page to the right side menu:
    image

Events from years 2020-2025 are not included in this PR, I will create a separate one.

sy-records, pronskiy, saundefined, and yourpayments reacted with thumbs up emoji
Copy link
Contributor

github-actions bot commented Jun 23, 2025 •
edited
Loading

🚀 Regression report for commit 187070c is at https://web-php-regression-report-pr-1284.preview.thephp.foundation

Copy link
Contributor

github-actions bot commented Jun 23, 2025 •
edited
Loading

🚀 Preview for commit 187070c can be found at https://web-php-pr-1284.preview.thephp.foundation

Copy link
Member

Looks great, thanks!

Please note Sara's comment (I suppose we can wait for others to weigh in as well).

IMO: I don't see a problem with web-php review for changes like this, as it's no more work than user conference review, but I'd be happy to hear from others.
mkurzeja reacted with thumbs up emoji

Copy link
Author

Thanks, I get the point with the wiki idea, I just struggle a bit with some flows around it. Will summarize everything and reply to the comment directly.

Something strange happened with the visual regression test. Screen was updated, yet if failed again. I will check this again.

Copy link
Author

@saundefined we are now working on running the visual tests locally, so we can check why it fails.
saundefined reacted with thumbs up emoji

Copy link
Member

@mkurzeja the last visual test looks awesome! 🎉
mkurzeja reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saundefined saundefined Awaiting requested review from saundefined saundefined is a code owner

@sy-records sy-records Awaiting requested review from sy-records sy-records is a code owner

@sgolemon sgolemon Awaiting requested review from sgolemon sgolemon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /