-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-20906: Assertion failure when messing up output buffers #20908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Girgias
Girgias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if a better change for master is to make the highlighter not rely on the output buffering as it seems it gets discarded anyway in some cases.
ndossche
commented
Jan 11, 2026
It's not getting discarded. Either returned as string or sent to the output
Girgias
commented
Jan 11, 2026
It's not getting discarded. Either returned as string or sent to the output
Right, I meant "discarded" when returning it as a string, which I guess ideally shouldn't rely on the output buffering.
No description provided.