-
Notifications
You must be signed in to change notification settings - Fork 437
Run CI tests in php 8.3 in CI #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amenophis
commented
Mar 22, 2024
@makasim Could you please authorize the workflow run to see the state of tests 🙏
3c62316 to
c46ce4e
Compare
amenophis
commented
Mar 25, 2024
@makasim Thanks for merging the other PR, could you restart the CI please ?
amenophis
commented
Apr 5, 2024
Hi @makasim
It seems the php 8.3 images added by makasim/docker-nginx-php-fpm#9 are not available on the docker registry.
Did you build and push them ?
Thanks 🙏
Nope, but I'll try on weekends. (feel free to ping me the next week).
amenophis
commented
Apr 8, 2024
Hi @makasim
Since the image for php 8.3 was just built, could you restart the CI on this branch ?
Thanks 🙏
makasim
commented
Apr 8, 2024
btw, you can drop too old versions if they fail ( do not spent time fixing them).
makasim
commented
Apr 8, 2024
symfony 5.46円.3 and php 8.4 would be enough
amenophis
commented
Apr 8, 2024
@makasim I did some fixes in the CI, and restrict version to PHP 8.2/8.3 and Symfony 5.5/6.4 for now.
Can you restart the CI please ?
🙏
812fb69 to
46892dd
Compare
amenophis
commented
Apr 9, 2024
Hi @makasim
It seems that failed tests are flaky, so could you please retry them ?
Is it normal that it donesn't automatically start on new commit ?
Thanks 🙏
amenophis
commented
Apr 15, 2024
Hi @makasim
Could you retry last CI run ?
Thanks 🙏
Hi,
This PR allows to run the CI on php 8.3