-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
buffer: recreate pooled ArrayBuffer after transfer #61364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lindsaycode05
wants to merge
1
commit into
nodejs:main
from
lindsaycode05:fix/buffer-transfer-pooled-ab
Open
buffer: recreate pooled ArrayBuffer after transfer #61364
lindsaycode05
wants to merge
1
commit into
nodejs:main
from
lindsaycode05:fix/buffer-transfer-pooled-ab
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nodejs-github-bot
nodejs-github-bot
added
buffer
Issues and PRs related to the buffer subsystem.
needs-ci
PRs that need a full CI run.
labels
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61362
Summary
ArrayBuffer.prototype.transfer()), subsequentBuffer.from(..., 'base64')calls would throwERR_BUFFER_OUT_OF_BOUNDS. This change ensures pooled Buffer creation doesn’t rely on a detached pool ArrayBuffer.Repro
Changes
Buffer.fromafter transfer.Tests
python3 tools/test.py test/parallel/test-buffer-pool-untransferable.jsmake -j4 test