-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
fs: remove duplicate fd validation in sync functions #61361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mertcanaltin
wants to merge
1
commit into
nodejs:main
from
mertcanaltin:mert/fs-optimize-sync-fd-check
Open
fs: remove duplicate fd validation in sync functions #61361
mertcanaltin
wants to merge
1
commit into
nodejs:main
from
mertcanaltin:mert/fs-optimize-sync-fd-check
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nodejs-github-bot
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
labels
Jan 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #61361 +/- ## ========================================== + Coverage 88.51% 88.53% +0.01% ========================================== Files 704 704 Lines 208739 208732 -7 Branches 40274 40270 -4 ========================================== + Hits 184770 184795 +25 + Misses 15968 15942 -26 + Partials 8001 7995 -6
🚀 New features to boost your workflow:
|
avivkeller
avivkeller
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I removed the repeated fd validation in synchronization functions; C++ already validates this via GetValidatedFd.
Asynchronous functions keep JS validation for error ordering.
readSync: 1,793K → 1,923K ops/sec
passed all fs tests
test-fs-read.js
test-fs-write.js
test-fs-readv-sync.js
test-fs-writev-sync.js