zlib: validate write_result array length #61342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

islandryu wants to merge 2 commits into nodejs:main

from islandryu:61286

Open

zlib: validate write_result array length #61342

islandryu wants to merge 2 commits into nodejs:main from islandryu:61286

+3 −0

Conversation

@islandryu

Copy link

Member

@islandryu islandryu commented Jan 11, 2026

Fixes: #61286

@islandryu


 zlib: validate write_result array length

07320af

Fixes: nodejs#61286

@nodejs-github-bot nodejs-github-bot added c++ needs-ci zlib labels

Jan 11, 2026

@codecov

Copy link

codecov bot commented Jan 11, 2026 •

edited

Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (5d9855b) to head (590b0bb).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_zlib.cc	0.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@
## main #61342 +/- ##
=======================================
 Coverage 88.52% 88.53% 
=======================================
 Files 704 704 
 Lines 208739 208742 +3 
 Branches 40280 40281 +1 
=======================================
+ Hits 184787 184803 +16 
+ Misses 15969 15929 -40 
- Partials 7983 8010 +27

Files with missing lines	Coverage Δ
src/node_zlib.cc	`77.57% <0.00%> (-0.61%)`	⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.