-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
lib: return undefined for localStorage without file #61333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ebc1299 to
c85a48b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #61333 +/- ## ========================================== - Coverage 88.54% 88.51% -0.04% ========================================== Files 704 704 Lines 208734 208762 +28 Branches 40271 40272 +1 ========================================== - Hits 184823 184778 -45 - Misses 15932 15977 +45 - Partials 7979 8007 +28
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you keep this call the same, and do something like
ObjectDefineProperty(globalThis, 'localStorage', { enumerable: ... });
Instead of re-writing the whole implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I don't understand what you are asking.
c85a48b to
5b17977
Compare
Make localStorage return undefined and emit a warning when
--localstorage-file is not provided. Mark the property as
non-enumerable to avoid breaking {...globalThis}.
Fixes: nodejs#60303
5b17977 to
b044f0a
Compare
Make localStorage return undefined and emit a warning when
--localstorage-file is not provided. Mark the property as
non-enumerable to avoid breaking {...globalThis}.
Fixes: #60303