Support llvm dev releases #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

trxcllnt wants to merge 8 commits into nodejs:main

from trxcllnt:fix/use-llvm-dev-branch

Open

Support llvm dev releases #433

trxcllnt wants to merge 8 commits into nodejs:main from trxcllnt:fix/use-llvm-dev-branch

Conversation

@trxcllnt

Copy link

Contributor

@trxcllnt trxcllnt commented Mar 7, 2024

This is a followup to #389:

Updates the range of LLVM versions we check (from 20, which is next dev version, to 99)
Support downloading headers if the detected lldb version is the current dev release
- i.e. doesn't have a release/XY.x branch, but does have a llvmorg-XY-init tag
Update the PR action to test ubuntu-22.04 + LLVM versions up to current dev (v19)

If we wanted to be fancy, we could populate the supported versions and CI matrix by parsing git ls-remote --tags https://github.com/llvm/llvm-project.git 'refs/tags/llvmorg-*-init'.

Let me know if that's something you'd like me to add!

trxcllnt added 3 commits

March 6, 2024 16:30

@trxcllnt


 expand the number of possible future LLVM versions to 99

41f395d

@trxcllnt


 check to see if the LLVM version is the current dev release

3b6dd74

@trxcllnt


 update github workflow to test more LLVM versions, including the curr...

2f7f284

...ent dev release, and ubuntu22.04

@codecov-commenter

Copy link

codecov-commenter commented Mar 7, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.75%. Comparing base (de1f01d) to head (1d965d1).

Additional details and impacted files

@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 74.25% 73.75% -0.51% 
==========================================
 Files 34 34 
 Lines 4999 5181 +182 
==========================================
+ Hits 3712 3821 +109 
- Misses 1287 1360 +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trxcllnt added 2 commits

March 6, 2024 16:51

@trxcllnt


 update linter job to use lldb-11

460472d

@trxcllnt


 parse the python version from the python3 binary

c924ad9

trxcllnt

trxcllnt commented

Mar 7, 2024

View reviewed changes

.github/workflows/push.yml

Comment on lines +116 to +118

# Is `/usr/lib/lib` here correct?

sudo mkdir -p /usr/lib/lib/python${python_version}

sudo ln -s /usr/lib/llvm-${{ matrix.llvm }}/lib/python${python_version}/site-packages /usr/lib/lib/python${python_version}/site-packages

Copy link

Contributor Author

@trxcllnt trxcllnt Mar 7, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment here, not sure what symlinking to /usr/lib/lib is doing?

trxcllnt

trxcllnt commented

Mar 7, 2024

View reviewed changes

.github/workflows/push.yml

Comment on lines +155 to +156

sudo apt-get install lldb-11 liblldb-11-dev lcov -y

sudo ln -s $(which lldb-11) /usr/bin/lldb

Copy link

Contributor Author

@trxcllnt trxcllnt Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated these to lldb-11 because ubuntu-latest is now jammy

trxcllnt

trxcllnt commented

Mar 7, 2024

View reviewed changes

.github/workflows/push.yml

Comment on lines 51 to 82

use_llvm_repos=1

case "${{ matrix.os }}-${{ matrix.llvm }}" in

ubuntu-18.04-10) use_llvm_repos=1;;

ubuntu-18.04-11) use_llvm_repos=1;;

ubuntu-18.04-12) use_llvm_repos=1;;

ubuntu-18.04-13) use_llvm_repos=1;;

ubuntu-18.04-14) use_llvm_repos=1;;

ubuntu-20.04-13) use_llvm_repos=1;;

ubuntu-20.04-14) use_llvm_repos=1;;

*) use_llvm_repos=0;;

case "${{ matrix.os }}" in

ubuntu-18.04)

case "${{ matrix.llvm }}" in

8) use_llvm_repos=0;;

9) use_llvm_repos=0;;

10) use_llvm_repos=0;;

*) use_llvm_repos=1;;

esac

;;

ubuntu-20.04)

case "${{ matrix.llvm }}" in

8) use_llvm_repos=0;;

9) use_llvm_repos=0;;

10) use_llvm_repos=0;;

11) use_llvm_repos=0;;

12) use_llvm_repos=0;;

*) use_llvm_repos=1;;

esac

;;

ubuntu-22.04)

case "${{ matrix.llvm }}" in

11) use_llvm_repos=0;;

12) use_llvm_repos=0;;

13) use_llvm_repos=0;;

14) use_llvm_repos=0;;

15) use_llvm_repos=0;;

*) use_llvm_repos=1;;

esac

;;

*) use_llvm_repos=1;;

Copy link

Contributor Author

@trxcllnt trxcllnt Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defaults to using the LLVM repos unless it's one of the versions packaged by Canonical. This should be a limited set, compared to the previous way which would need exceptions for every version not packaged by Canonical.

trxcllnt added 3 commits

March 6, 2024 17:14

@trxcllnt


 add llvm libs to ld config and regenerate ld cache

e030df1

@trxcllnt


 remove ubuntu18.04 because that runner type was removed by github, ad...

2348ceb

...d node 20.x

@trxcllnt


 add concurrency key

1d965d1

@trxcllnt

Copy link

Contributor Author

trxcllnt commented Jul 16, 2024 •

edited

Loading

It appears the lldb headers in llvm-19 now include headers generated by the build, so downloading them from github is insufficient to build llnode. I'm not sure what to do about that.

@No9 do you have any thoughts on this PR?

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Support llvm dev releases #433

Are you sure you want to change the base?

Support llvm dev releases #433

Uh oh!

Conversation

@trxcllnt trxcllnt commented Mar 7, 2024

Uh oh!

codecov-commenter commented Mar 7, 2024 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

@trxcllnt trxcllnt Mar 7, 2024 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@trxcllnt trxcllnt Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

@trxcllnt trxcllnt Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

trxcllnt commented Jul 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Support llvm dev releases #433

Are you sure you want to change the base?

Support llvm dev releases #433

Uh oh!

Conversation

@trxcllnt trxcllnt commented Mar 7, 2024

Uh oh!

codecov-commenter commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

@trxcllnt trxcllnt Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@trxcllnt trxcllnt Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

@trxcllnt trxcllnt Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

trxcllnt commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov-commenter commented Mar 7, 2024 •

edited

Loading

@trxcllnt trxcllnt Mar 7, 2024 •

edited

Loading

trxcllnt commented Jul 16, 2024 •

edited

Loading