-
-
Notifications
You must be signed in to change notification settings - Fork 101
Add "v8 version" subcommand to llnode #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the new feature support in Mac OS system? As far as I know, option P is not supported in grep in Mac OS, neither as \K
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a compile-time step, so technically the feature would support any OS once we have a built artifact, but you're right that this wouldn't build on MacOS. We can change this line to:
"cflags": [ '-DLLNODE_VERSION=<!(grep \\"version\\" <(module_root_dir)/package.json | sed \'s/.*\\("[0-9\\.]*"\\).*/\1円/g\')' ],
if that works on Mac? Although I guess that also brings up the issue of Windows...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I confirm that it should work on Mac. and I think the double \ in \\"version\\" can be replaced by single \.
In particular, I tried grep "version" < package.json | sed 's/.*\("[0-9\.]*"\).*/1円/g' and echo "$(grep \"version\" < package.json | sed 's/.*\("[0-9\.]*"\).*/1円/g')"in cli.
vprab
commented
Oct 3, 2023
Tagging @danielleadams for visibility 😄
Fixes: #194