-
-
Notifications
You must be signed in to change notification settings - Fork 101
Compilation warnings #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Compilation warnings #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with gcc-10.2.0 this would emit a warning
When compiling under gcc-10.2.0 this line would emit a warning
When compiling under gcc-10.2.0 this would emit a warning
When compiling under gcc-10.2.0 this would emit a warning By escaping the '?' it will no longer be detected as a trigraph.
When compiling all warnings will now be treated as an error, preventing potentially misbehaving code from making it onto master.
When executing tests with gdb-9.2 and lldb-10.0.1 the tests would fail. Relaxing the error assertion to only check for the warning itself, not the location fixes the test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #374 +/- ## ========================================== - Coverage 79.53% 79.00% -0.54% ========================================== Files 33 33 Lines 4744 4743 -1 ========================================== - Hits 3773 3747 -26 - Misses 971 996 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with gcc-10.2.0 there are some warnings emitted.
The unit tests were failing when using gdb-9.2 and lldb-10.0.1 as the line would change from
to
This relaxes the test just enough to also work with older versions of gdb & lldb where this location information would not be included.