-
-
Notifications
You must be signed in to change notification settings - Fork 110
Add method Selection::havingOr #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30f8fa0 to
5d5ecea
Compare
dakujem
commented
Nov 26, 2019
Hello, David. Does this look good to you? I will eventually solve the currently present issues, I hope. I'm in a hurry now though.
Sidenote: I spent unnecessary time to find out how to run the tests so that most of them are not skipped... May I suggest adding a brief info for other devs how to run the tests?
dakujem
commented
Nov 26, 2019
Another sidenote: I was wondering why are the two methods (where and having) so inconsistent. Why does having only accept a string, while where will happily accept an array of string as well? All the while multiple calls to having will overwrite the HAVING condition, while multiple calls to where will add more WHERE conditions. This I find suboptimal, as both HAVING and WHERE are similar in the way the resulting SQL is built.
dg
commented
Nov 26, 2019
Does this look good to you?
Thanks, it looks great!
I spent unnecessary time to find out how to run the tests so that most of them are not skipped... May I suggest adding a brief info for other devs how to run the tests?
That would be great, I don't realize these things. Maybe add it to a the file contributing.md?
I was wondering why are the two methods (where and having) so inconsistent.
Unfortunately, I don't know, I'm not an author. It could be unified, but I don't know how big a BC break would be.
f9fc19d to
dd75e74
Compare
cce6a9c to
7e705c5
Compare
9acf825 to
a268c60
Compare
a56e7fe to
d9b5f29
Compare
f016c33 to
6596c77
Compare
a9e5763 to
c3cc31a
Compare
e91b234 to
953502b
Compare
f8de9c7 to
52d72e1
Compare
cdb8832 to
a1798c0
Compare
1769a67 to
b02f117
Compare
2d78899 to
2f04c73
Compare
e8459f8 to
23617a8
Compare
2da238e to
038bab3
Compare
d3018bd to
9dc391a
Compare
havingOr? #240 )Adds
Selection::havingOrmethod analogously to theSelection::whereOr, refactoring the common logic into a separate protected method (Selection::paramsOr).closes #240