Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix missing std::char_traits<uint8_t> (if it is in fact missing). #1812 #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leakingmemory wants to merge 4 commits into microsoft:master
base: master
Choose a base branch
Loading
from leakingmemory:bug/char-traits-uint8-issue-1812

Conversation

@leakingmemory
Copy link

@leakingmemory leakingmemory commented Jun 21, 2025

No description provided.

Copy link
Author

@microsoft-github-policy-service agree

...tion function of print/format through the specializations leading to infinite recursion. Fixes streams_test broken by the char_traits fixes. Unfortunately reuires some extra string copying because the std streams library really really doesn't work well on anything but char (signed) types on gcc and llvm, so general advice seems to be to convert to char on the way in and back to unsigned on the way out if one really need the std streams library to work on unsigned types. microsoft#1812 
Copy link
Author

Just to clarify on this. My personal opinion is that it is better to break compatibility and fix this by not using unsigned char types with C++ streams. It has worked fine on some compilers and standard libraries, but to my knowledge only char types are supported by the C++ standard. This pull request was made with the intention to not break compatibility with existing code.

Copy link

yuxiang-wen commented Oct 23, 2025 via email

收到,谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /