Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix issue: The web_proxy doesn't work when set proxy with uri #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ceasor wants to merge 1 commit into microsoft:master
base: master
Choose a base branch
Loading
from ceasor:master

Conversation

@ceasor
Copy link

@ceasor ceasor commented Nov 23, 2023
edited
Loading

http_client_winhttp::send_request only handle the case when proxy.is_auto_discovery() return true.
image
So when we construct a web_proxy with uri, it will only set the proxy mode as user_provided_.
image
So send_request will ignore the proxy setting when we use uri to construct a web_proxy.

My modification tries to fix the problem.

Copy link
Author

ceasor commented Nov 23, 2023

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /