-
Notifications
You must be signed in to change notification settings - Fork 302
Enhance get_channels_with_hash() #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To set the index 0 name to the preset name from localConfig.lora.modem_prese and compute hash so the output will not have bad index0 name or hash, also removes all disabled for clarity. this outputs `Device1 Channel Hash Table: [{'index': 0, 'role': 'PRIMARY', 'name': 'LongFast', 'hash': 8}` for a LongFast
@ianmcorvidae
ianmcorvidae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of issues here -- the generated names won't always be right as-is and this needs to be done for secondary channels too. But a good change in general/otherwise
Co-authored-by: Ian McEwen <ian@ianmcorvidae.net>
modem preset is set to none, the name used should be Custom
refactoring per comments in meshtastic#859
SpudGunMan
commented
Nov 23, 2025
A couple of issues here -- the generated names won't always be right as-is and this needs to be done for secondary channels too. But a good change in general/otherwise
refactored to handle issues I hope?
To set the index 0 name to the preset name from localConfig.lora.modem_preset when empty
and compute hash so the output will not have bad index0 name or hash, also removes all disabled for clarity.
This outputs
Device1 Channel Hash Table: [{'index': 0, 'role': 'PRIMARY', 'name': 'LongFast', 'hash': 8}for a LongFast