-
Notifications
You must be signed in to change notification settings - Fork 920
Use nameof on arguments for Ensure
#2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkrejcha
wants to merge
1
commit into
libgit2:master
from
jkrejcha:20250212-use-nameof-where-parameter-name-expected
Open
Use nameof on arguments for Ensure
#2143
jkrejcha
wants to merge
1
commit into
libgit2:master
from
jkrejcha:20250212-use-nameof-where-parameter-name-expected
+337
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jkrejcha
jkrejcha
changed the title
(削除) Chore: use
(追記) Use Feb 12, 2025
nameof on arguments for Ensure (削除ここまで)nameof on arguments for Ensure (追記ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally where parameter names are mentioned, it's a best practice to use
the
nameof()expression. This patch adds it where stringified names werebeing used.