-
Notifications
You must be signed in to change notification settings - Fork 23
Multiple reports #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dannylewis-sheffield
wants to merge
3
commits into
leanphp:master
from
openbuild-sheffield:multiple-reports
Open
Multiple reports #22
dannylewis-sheffield
wants to merge
3
commits into
leanphp:master
from
openbuild-sheffield:multiple-reports
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ek9
commented
Mar 17, 2018
Hi,
Thank you for the PR. There are a few problems:
- The code update is very messy in
ReportService.php. The nested if/then/else is unclean and there should be a more clean way to handle this. - The code style is very different from the current coding style that project is using. I have made Add conding style guide and checker #25 so we have code style checks as part of the Travis.
- The travis build for your update contains errors (the tests fail). The tests must be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to allow multiple reports.
Sample behat.yml:
I've left the original report option as is, so no breaking changes.