-
Notifications
You must be signed in to change notification settings - Fork 57
fix: Add fastapi-app service to docker-compose.yml. #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pratik-mahalle
commented
Jun 27, 2025
Hey @maverickjit, Thank you for raising the changes. Our team will review the changes soon before that please make sure to sign the DCO
@pratik-mahalle
pratik-mahalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maverickjit, The fast-app service is already added in the repo.
You can check that here https://github.com/keploy/samples-python/blob/main/fastapi-postgres/docker-compose.yml
I really appreciate your effort. For now, we are closing this one!
🛠️ Description
This PR fixes Issue #13 by adding the missing
fastapi-appservice to thedocker-compose.ymlfile under thefastapi-postgressample.Previously, the FastAPI container was not defined in
docker-compose.yml, which preventedkeploy recordfrom detecting the application for testing.🔧 Changes Made
fastapi-appservice tofastapi-postgres/docker-compose.ymlkeploy recordto work as expected with FastAPI✅ How I Tested
docker-compose upto start both FastAPI and Postgreskeploy record -c "docker-compose up" --container-name fastapi-appto capture test cases successfully📌 Related Issue
Fixes #13
Let me know if there are additional changes or test scenarios you'd like me to add. Happy to iterate!
Screenshot 2025年06月19日 043156