Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Interaction: alert, prompt, confirm #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreimuntean1 wants to merge 4 commits into javascript-tutorial:master
base: master
Choose a base branch
Loading
from andreimuntean1:alert-prompt-confirm

Conversation

@andreimuntean1
Copy link

@andreimuntean1 andreimuntean1 commented Jan 23, 2023

No description provided.

Error: the article already has PR number in the Progress Issue #1, it's 170 !?️

Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Textul trebuie re-formatat.

.cache
.project
.settings
.vscode
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode

Nu trebuie să adăugăm setări care nu erau acolo

</script>

</body>
let name = prompt("Cum te numești?", "");
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presupun că ai o setare în VSCode care formatează textul.
Traducerea trebuie să aibă același format cu cel original. Dezactivează extensiile precum Prettier.

alert(`You are ${age} years old!`); // You are 100 years old!
```
alert(`Ai ${age} de ani!`); // Ai 100 de ani!
````
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atenție la formatare


```js run
let test = prompt("Test", ''); // <-- for IE
let test = prompt("Test", ""); // <-- pentru Internet Explorer
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let test = prompt("Test", ""); // <-- pentru Internet Explorer
let test = prompt("Test", ''); // <-- pentru Internet Explorer

formatare

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /