Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Loops: while and for #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreimuntean1 wants to merge 9 commits into javascript-tutorial:master
base: master
Choose a base branch
Loading
from andreimuntean1:while-for

Conversation

@andreimuntean1
Copy link

@andreimuntean1 andreimuntean1 commented Jan 23, 2023

No description provided.

andreimuntean1 and others added 8 commits January 23, 2023 13:57
This reverts that commit to be able to make a PR with only the translation regarding loops.
This reverts that commit to be able to make a PR with only the translation regarding loops.
This reverts that commit to be able to make a PR with only the translation regarding loops.
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codul trebuie revizuit pentru formatare corectă. Atenție deosebită la spații, linii și variabile.

De exemplu, bucla de mai jos afișează `i` cât timp `i < 3`:

```js run
```js
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```js
```js run

formatare, te rog sa faci la fel pentru fiecare instanță
Dacă apeși ctrl + D după ce ai evidențiat textul... apoi poți șterge și scrie toate erorile de-odată.

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link
Author

/done

Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trebuie verificare liniile: să nu fie linii șterse sau adăugate.
Trebuie verificat ca formatarea să coincidă cu originalul. (în setări la VSCode trebuie să dezactivezi formatarea automată)

```
Prima valoare este `i = 1` pentru că `++i` incrementează prima dată `i` și apoi returnează noua valoare. Așadar prima comparație este `1 < 5` și funcția `alert` afișează `1`.
2. **De la 1 la 5**

Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spațiile dintre linii trebuie lăsate cum sunt, altfel nu se văd bine diferențele dintre texte. vezi git diff

1. The prefix form `++i`:
1. Forma cu prefix `++i`:

```js
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatare

1. The postfix form:
1. Forma cu sufix:

```js
Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatare

@@ -1,5 +1,3 @@

Copy link
Contributor

@bogdanbacosca bogdanbacosca Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linii șterse

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /