JavaScript specials #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Onxi95 wants to merge 2 commits into javascript-tutorial:master

from Onxi95:master

Open

JavaScript specials #98

Onxi95 wants to merge 2 commits into javascript-tutorial:master from Onxi95:master

Conversation

@Onxi95

Copy link

@Onxi95 Onxi95 commented May 30, 2021

No description provided.

Onxi95 added 2 commits

May 30, 2021 13:56

@Onxi95


 javascript-specials polish translation

a8e4513

@Onxi95


 minor tweaks

0e8c179

@javascript-translate-bot javascript-translate-bot added the review needed label

May 30, 2021

@javascript-translate-bot javascript-translate-bot requested a review from a team

May 30, 2021 12:25

@CLAassistant

Copy link

CLAassistant commented May 30, 2021 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request

May 30, 2021

Polish Translation Progress #1

Open

deivuss331

deivuss331 requested changes

Jan 29, 2022

View reviewed changes

Copy link

Member

@deivuss331 deivuss331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make requested changes. Thank you!

1-js/02-first-steps/17-javascript-specials/article.md

```

Usually, a line-break is also treated as a delimiter, so that would also work:

Zwykle znak końca wiersza jest również traktowany jako separator, więc to działałby również:

Copy link

Member

@deivuss331 deivuss331 Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misspell in "działałby" word. Shouldn't it be "działałoby"?

1-js/02-first-steps/17-javascript-specials/article.md

```

Most codestyle guides agree that we should put a semicolon after each statement.

Większość wytycznych do stylów kodowania (ang. *codestyle guides*) twierdzi, że po każdym wyrażeniu należy umieścić średnik.

Copy link

Member

@deivuss331 deivuss331 Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add any phrases that weren't originally in sentence.
I'd also consider changing "Większość wytycznych do stylów kodowania" for "Większość styli kodowania" as it changes the original meaning IMO.

1-js/02-first-steps/17-javascript-specials/article.md

[`alert(message)`](mdn:api/Window/alert)

: Output a `message`.

[`alert(wiadomość)`](mdn:api/Window/alert)

Copy link

Member

@deivuss331 deivuss331 Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not modify any variable names

1-js/02-first-steps/17-javascript-specials/article.md

: Wyświetla `wiadomość`.

All these functions are *modal*, they pause the code execution and prevent the visitor from interacting with the page until they answer.

Wszystkie te funkcje są *modalne* (w postaci okien dialogowych), wstrzymują wykonywanie kodu i uniemożliwiają odwiedzającemu interakcję ze stroną, dopóki nie odpowie.

Copy link

Member

@deivuss331 deivuss331 Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add any special phrases like this one: "(w postaci okien dialogowych)"

1-js/02-first-steps/17-javascript-specials/article.md

Logical operators

: Logical AND `&&` and OR `||` perform short-circuit evaluation and then return the value where it stopped (not necessary `true`/`false`). Logical NOT `!` converts the operand to boolean type and returns the inverse value.

Operatory logiczne

: Logiczne ORAZ (ang. *AND*) `&&` i LUB (ang. *OR*) `||` wykonują ewaluację w postaci "zwarcia" (ang. *short-circuit evaluation*) a następnie zwracacją wartość w miejscu, w którym została zatrzymana (niekoniecznie`true`/`false`). Logiczne NIE (ang. *NOT*) `!` Konwertuje operand na typ boolowski i zwraca wartość odwrotną.