-
Notifications
You must be signed in to change notification settings - Fork 46
The modern mode, "use strict" #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
@rskhan167
rskhan167
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR. Good work, there's a few changes then we are good to go.
Also, please don't add or remove any line, a couple of places I have added a remark to remove extra line please compare with original file and check in other places too. Thanks.
javascript-translate-bot
commented
Oct 16, 2021
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@DKumar2169
DKumar2169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes have been made
rskhan167
commented
Oct 26, 2021
Hi @DKumar2169, I have reviewed your PR. Great work, it looks good. There were few changes needed like removal of extra space and line. I have committed those changes. Please have a look at it and let me know if anything needs to be changed. Then, we can merge it.
Made some changes Please review if I did this correct so I can work on it more