Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Remove six #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mic92 wants to merge 4 commits into html5lib:master
base: master
Choose a base branch
Loading
from Mic92:six
Draft

Remove six #581

Mic92 wants to merge 4 commits into html5lib:master from Mic92:six

Conversation

@Mic92
Copy link

@Mic92 Mic92 commented Sep 9, 2024

Depends on #580

a-detiste and selfisekai reacted with thumbs up emoji
Mic92 added 4 commits September 9, 2024 10:16 
ruff check --target-version py38 --select UP --fix .
Even debian oldstable has python 3.9. For internet-facing libraries it
is not secure for contributor to install unsupported python versions in order to test them.
Reducing the number of python versions will make maintenance and testing easier.
is not secure to contributor to install unsupported python versions in order to test them.
Copy link
Author

Mic92 commented Sep 9, 2024

I will continue to look at this when #580 is merged. Currently it still has some errors in it.

Copy link

Hi @Mic92
I am pulling this PR (and #580) into a custom html5lib fork for my personal project.
Can you tell me what errors you are still seeing after these commits?

Copy link

@Mic92 I found two, on line 133 and 135 of _inputstream.py you need to replace text_type with str.
After doing that, all tests pass.

Copy link
Author

Mic92 commented Sep 25, 2024

I was mainly looking at the test suite failing.

Copy link
Author

Mic92 commented Sep 25, 2024

Good to know there is a potential fork to switch to in the future.

Copy link

ashleysommer commented Sep 25, 2024 •
edited
Loading

Good to know there is a potential fork to switch to in the future.

@Mic92
Its now published here:
https://pypi.org/project/html5lib-modern/

a-detiste reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /