-
Notifications
You must be signed in to change notification settings - Fork 265
Fix pure cpp1 header file generated using -import-std #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pure cpp1 header file generated using -import-std #1319
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
31e6312 to
df266a6
Compare
gregmarr
commented
Oct 17, 2024
A source without Cpp2 should be pass-through
(i.e., the Cpp2 source and the generated Cpp1 source should compare equal).
Unless you specify the flag to either import or include the standard library, then it adds extra stuff.
Lines 1298 to 1305 in 68b716a
source/to_cpp1.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(flag_import_std || flag_include_std) to match
Lines 1301 to 1305 in 68b716a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I force-pushed with your suggestion. Thanks 😊
df266a6 to
ed1fa67
Compare
hsutter
commented
Oct 31, 2024
Thanks for your pull request! It looks like this may be your first contribution to cppfront. I've emailed you the Contributor License Agreement (CLA), and once it's completed I can look at your pull request. Thanks again for your contribution.
Uh oh!
There was an error while loading. Please reload this page.
I've noticed that if I execute
cppfront.exewith the-import-stdoption on a .h file that doesn't contain any cpp2 code, then an#endifwill be missing at the end of the file. See #1320 for more info.