Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

JS: Add support for props callbacks in Vue router configs #21159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asgerf wants to merge 3 commits into github:main
base: main
Choose a base branch
Loading
from asgerf:js/vue-prop-function
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/ql/lib/semmle/javascript/frameworks/Vue.qll
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,10 @@ module Vue {
or
result = routeConfig().getMember("beforeEnter").getParameter([0, 1]).asSource()
or
result = routeConfig().getMember("props").getParameter(0).asSource()
or
result = routeConfig().getMember("props").getAMember().getParameter(0).asSource()
or
exists(Component c |
result = c.getABoundFunction().getAFunctionValue().getReceiver().getAPropertyRead("$route")
or
Expand Down
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
category: minorAnalysis
---
* The model of `vue-router` now properly detects taint sources in cases where
the `props` property is a callback.
14 changes: 11 additions & 3 deletions javascript/ql/test/library-tests/frameworks/Vue/router.js
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,17 @@ export const router = new Router({
from.query.x;
}
}
]
}
],
props: route => ({
x: route.query.x
}),
},
{
props: {
x: route => route.query.x,
y: route => route.query.y
},
},
],
scrollBehavior(to, from, savedPosition) {
to.query.x;
Expand All @@ -34,4 +43,3 @@ router.afterEach((to, from) => {
to.query.x;
from.query.x;
});

30 changes: 18 additions & 12 deletions javascript/ql/test/library-tests/frameworks/Vue/tests.expected
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,15 @@ remoteFlowSource
| router.js:9:17:9:26 | from.query |
| router.js:15:25:15:32 | to.query |
| router.js:16:25:16:34 | from.query |
| router.js:23:9:23:16 | to.query |
| router.js:24:9:24:18 | from.query |
| router.js:29:5:29:12 | to.query |
| router.js:30:5:30:14 | from.query |
| router.js:34:5:34:12 | to.query |
| router.js:35:5:35:14 | from.query |
| router.js:21:20:21:30 | route.query |
| router.js:26:29:26:39 | route.query |
| router.js:27:29:27:39 | route.query |
| router.js:32:9:32:16 | to.query |
| router.js:33:9:33:18 | from.query |
| router.js:38:5:38:12 | to.query |
| router.js:39:5:39:14 | from.query |
| router.js:43:5:43:12 | to.query |
| router.js:44:5:44:14 | from.query |
parseErrors
attribute
| compont-with-route.vue:2:8:2:21 | v-html=dataA | v-html |
Expand Down Expand Up @@ -227,12 +230,15 @@ threatModelSource
| router.js:9:17:9:26 | from.query | remote |
| router.js:15:25:15:32 | to.query | remote |
| router.js:16:25:16:34 | from.query | remote |
| router.js:23:9:23:16 | to.query | remote |
| router.js:24:9:24:18 | from.query | remote |
| router.js:29:5:29:12 | to.query | remote |
| router.js:30:5:30:14 | from.query | remote |
| router.js:34:5:34:12 | to.query | remote |
| router.js:35:5:35:14 | from.query | remote |
| router.js:21:20:21:30 | route.query | remote |
| router.js:26:29:26:39 | route.query | remote |
| router.js:27:29:27:39 | route.query | remote |
| router.js:32:9:32:16 | to.query | remote |
| router.js:33:9:33:18 | from.query | remote |
| router.js:38:5:38:12 | to.query | remote |
| router.js:39:5:39:14 | from.query | remote |
| router.js:43:5:43:12 | to.query | remote |
| router.js:44:5:44:14 | from.query | remote |
| single-component-file-1.vue:7:45:7:54 | this.input | view-component-input |
| single-file-component-3-script.js:5:42:5:51 | this.input | view-component-input |
| single-file-component-4.vue:21:14:21:23 | this.input | view-component-input |
Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /