Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Prepare dataflow for local annotations #21138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tausbn wants to merge 6 commits into main
base: main
Choose a base branch
Loading
from tausbn/python-prepare-for-overlay-annotations

Conversation

@tausbn
Copy link
Contributor

@tausbn tausbn commented Jan 9, 2026

This PR contains all of the changes that are needed in order to get all of the overlay[local] annotations to compile.

@tausbn tausbn force-pushed the tausbn/python-prepare-for-overlay-annotations branch 2 times, most recently from 8c13fc5 to 4ad5118 Compare January 9, 2026 15:23
Removes the dependence on the (global) `ModuleVariableNode.getARead()`,
by adding a local version (that doesn't include `import *` reads)
instead.
@tausbn tausbn force-pushed the tausbn/python-prepare-for-overlay-annotations branch from 4ad5118 to 832d6fb Compare January 9, 2026 15:38
This may result in more nodes, but it should still be bounded by the
number of global variables in the source code.
@tausbn tausbn force-pushed the tausbn/python-prepare-for-overlay-annotations branch from e5b485f to fc43d22 Compare January 9, 2026 17:01
tausbn added 3 commits January 9, 2026 17:12
With `ModuleVariableNode`s now appearing for _all_ global variables (not
just the ones that actually seem to be used), some of the tests changed
a bit. Mostly this was in the form of new flow (because of new nodes
that popped into existence). For some inline expectation tests, I opted
to instead exclude these results, as there was no suitable location to
annotate. For the normal tests, I just accepted the output (after having
vetted it carefully, of course).
Overriding both `argumentOf` and `toString` was causing sadness for the
local annotations. Easiest fix was to split these out into their own
subclasses. The names are perhaps a bit too verbose now (alternative
suggestions are welcomed).
@tausbn tausbn force-pushed the tausbn/python-prepare-for-overlay-annotations branch 3 times, most recently from 6c95109 to 45e4b92 Compare January 13, 2026 13:33
We just create one for each call, not just the ones that capture
variables.
In the process, we also made the node synthetic, rather than overriding
the behaviour of (some) `ControlFlowNode`s.
@tausbn tausbn force-pushed the tausbn/python-prepare-for-overlay-annotations branch 2 times, most recently from 45e4b92 to 1242a7b Compare January 13, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /