-
Notifications
You must be signed in to change notification settings - Fork 794
Added prepare script to package.json #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since npm@5.0.0 the prepare script is called when the library is installed from github url. Aim of the script is to build distribution files. See npm/npm#3055
Member
j-rewerts
commented
Apr 7, 2019
Here is NPM's docs on it. This seems to work for me. It automatically builds the project when I run npm install, which is convenient. I'm still not 100% on how this impacts our build process though, since we support Node 4, which doesn't run this.
I think we should probably wait until we get our tests passing, then rerun our CI for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since npm@5.0.0 the prepare script is called
when the library is installed from github url.
Aim of the script is to build distribution
files.
See npm/npm#3055