-
Notifications
You must be signed in to change notification settings - Fork 572
ci: DRY ruff calls #5267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: DRY ruff calls #5267
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is okay. Explicitly saying that files shouldn't be changed doesn't yield a benefit on CI.
6037f2a to
ade2e99
Compare
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (2ce4379) to head (ade2e99).
Additional details and impacted files
@@ Coverage Diff @@ ## master #5267 +/- ## ========================================== - Coverage 84.25% 84.17% -0.08% ========================================== Files 181 182 +1 Lines 18463 18656 +193 Branches 3288 3316 +28 ========================================== + Hits 15556 15704 +148 - Misses 1894 1938 +44 - Partials 1013 1014 +1
Description
I was checking the lint setup and realized running pre-commit locally on latest main doesn't produce a clean result. I checked why this wasn't the case on CI and found out that pre-commit ruff and CI ruff use slightly different configuration. I tried to centralize that config, and found out there is a bug with ruff-pre-commit but still DRY'ed the ruff calls.
Considering the removal of the "include" setting causes only a single change in a single file, I think that settings can be removed compeletely but I didn't want to change configuration without asking about it first.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)