-
Notifications
You must be signed in to change notification settings - Fork 572
fix(litellm): fix gen_ai.request.messages to be as expected
#5255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(litellm): fix gen_ai.request.messages to be as expected
#5255
Conversation
...inal messages and handle data URLs correctly
Semver Impact of This PR
🟢 Patch (bug fixes)
📋 Changelog Preview
This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).
New Features ✨
- feat(ai): add parse_data_uri function to parse a data URI by constantinius in
#5311 - feat(asyncio): Add on-demand way to enable AsyncioIntegration by sentrivana in
#5288
Bug Fixes 🐛
Litellm
- fix(litellm): fix
gen_ai.request.messagesto be as expected by constantinius in#5255
- fix(litellm): Guard against module shadowing by alexander-alderman-webb in
#5249
Other
- fix(ai): redact message parts content of type blob by constantinius in
#5243 - fix(clickhouse): Guard against module shadowing by alexander-alderman-webb in
#5250 - fix(gql): Revert signature change of patched gql.Client.execute by alexander-alderman-webb in
#5289 - fix(grpc): Derive interception state from channel fields by alexander-alderman-webb in
#5302 - fix(pure-eval): Guard against module shadowing by alexander-alderman-webb in
#5252 - fix(ray): Guard against module shadowing by alexander-alderman-webb in
#5254 - fix(threading): Handle channels shadowing by sentrivana in
#5299 - fix(typer): Guard against module shadowing by alexander-alderman-webb in
#5253 - fix: Send client reports for span recorder overflow by sentrivana in
#5310
Documentation 📚
- docs(metrics): Remove experimental notice by alexander-alderman-webb in
#5304 - docs: Update Python versions banner in README by sentrivana in
#5287
Internal Changes 🔧
Release
- ci(release): Bump Craft version to fix issues by BYK in
#5305 - ci(release): Switch from action-prepare-release to Craft by BYK in
#5290
Other
- chore(gen_ai): add auto-enablement for google genai by shellmayr in
#5295 - chore: Add type for metric units by sentrivana in
#5312 - ci: Update tox and handle generic classifiers by sentrivana in
#5306
🤖 This preview updates automatically when you update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-base64 data URIs incorrectly converted to blob type
Medium Severity
The _convert_message_parts function converts ALL data URIs starting with data: to blob type, but the test test_convert_message_parts_data_url_without_base64 expects non-base64 data URIs (like data:image/png,rawdata) to be converted to uri type instead. The parse_data_uri function successfully parses any data URI with a comma, so the exception-based fallback to uri type never triggers for valid non-base64 data URIs. The code needs to check for ;base64 in the data URI header before treating it as a blob.
Issues
Closes https://linear.app/getsentry/issue/TET-1635/redact-images-litellm