-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Trace continuation from server-timing headers #18673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+402
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
This comment was marked as outdated.
This comment was marked as outdated.
...ration-tests/suites/tracing/trace-lifetime/tracing-without-performance-headers/template.html
Show resolved
Hide resolved
Lms24
Lms24
reviewed
Jan 2, 2026
Member
@Lms24
Lms24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this functionality, Tim!
If you don't mind, please also add an integration test with regular tracing. I think we have some meta-tags integration tests in our suites that we can take inspiration from.
...ration-tests/suites/tracing/trace-lifetime/tracing-without-performance-headers/template.html
Outdated
Show resolved
Hide resolved
dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-headers/test.ts
Outdated
Show resolved
Hide resolved
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
@timfish
timfish
force-pushed
the
timfish/feat/browser-server-timing
branch
from
January 3, 2026 15:06
d3377e1 to
3590824
Compare
@timfish
timfish
force-pushed
the
timfish/feat/browser-server-timing
branch
from
January 3, 2026 15:26
3590824 to
f8ce616
Compare
timfish
timfish
commented
Jan 3, 2026
span_id: expect.stringMatching(/^[\da-f]{16}$/),
});
// navigation span is head of trace, so there's no parent span:
expect(navigationTraceContext?.trace_id).not.toHaveProperty('parent_span_id');
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor pointed out that the type/logic was wrong in this expection...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Currently the only way to propagate trace context from server to browser is via meta tags. In some cases modifying the page HTML can be difficult or have a performance impact.
This PR adds support to the browser SDK to fetch
sentry-traceandbaggagefrom the Server Timing header.Closes #18678 (added automatically)