-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Add environment variable expansion for docker config plugin dirs #6487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add environment variable expansion for docker config plugin dirs #6487
Conversation
1759e72 to
d91b9d5
Compare
Paulchen5
commented
Oct 1, 2025
Hi @vvoland, any updates on this?
f9717ab to
c3326fd
Compare
vvoland
commented
Oct 2, 2025
LGTM after squashing commits
thaJeztah
commented
Oct 2, 2025
I'm slightly on the fence; wondering; does the (for the example) $HOMEBREW_PREFIX env-var ever change? And would it be an option to expand the env-var before adding the path to the config?
The point here is that we don't to env-var expansion for any of the other paths, so this may now become a sliding slope where it needs to be added to every path that's in config; the extraPaths was already added to allow customisation with a custom set of extra directories.
Paulchen5
commented
Oct 2, 2025
I'm slightly on the fence; wondering; does the (for the example)
$HOMEBREW_PREFIXenv-var ever change? And would it be an option to expand the env-var before adding the path to the config?
In general the $HOMEBREW_PREFIX env-var shouldn't really change as far as I know. At least when using standard configuration. However when writing a guide for example it's more helpful / clear wo write the path with the prefix into the guide so the reader has to think less about the content. So I think it would be a nice and helpful feature which shouldn't break somethin.
The point here is that we don't to env-var expansion for any of the other paths, so this may now become a sliding slope where it needs to be added to every path that's in config; the extraPaths was already added to allow customisation with a custom set of extra directories.
Feel free to tell me about the option names / code files and I will have a look whether I can implement it for the additional options
...gins/manager/manager.go` test: Add test for plugin directory environment variable expansion Signed-off-by: Paulchen <lukas.23022005@gmail.com>
c3326fd to
da71a33
Compare
Paulchen5
commented
Oct 2, 2025
LGTM after squashing commits
done 👍
Paulchen5
commented
Oct 18, 2025
Hey @vvoland are the changes fine and is it fine when I ping you? I don't wanna annoy you 😅
Uh oh!
There was an error while loading. Please reload this page.
- What I did
Closes #6486
- How I did it
- How to verify it
- Human readable description for the release notes
Add support to expand environment variables in docker plugin config directory string
- Add support to expand environment variables in docker plugin config directory stringI am really really new to Go like
0.5%experience. The test is mainly assisted by Copilot with a bit of brain usage by my side. Feel free to help me to add like a negative test or something like that if the current one is not enough- A picture of a cute animal (not mandatory but encouraged)
ducks