-
Notifications
You must be signed in to change notification settings - Fork 2.1k
cli/config: some minor cleanups #6352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thaJeztah
thaJeztah
added
status/2-code-review
kind/refactor
PR's that refactor, or clean-up code
labels
Aug 23, 2025
codecov-commenter
commented
Aug 23, 2025
Codecov Report
✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know!
Member
Author
thaJeztah
commented
Aug 23, 2025
Hm... I messed up something;
#18 64.05 === FAIL: cli/config/configfile TestGetAllCredentialsCredsStore (0.00s)
#18 64.05 file_test.go:238: assertion failed:
#18 64.05 --- expected
#18 64.05 +++ authConfigs
#18 64.05 map[string]types.AuthConfig{
#18 64.05 - "example.com": {Username: "user", Password: "pass"},
#18 64.05 }
#18 64.05
#18 64.05 file_test.go:239: assertion failed: 1 (int) != 0 (testCredsStore.(*mockNativeStore).GetAllCallCount int)
#18 64.05
#18 64.05 === FAIL: cli/config/configfile TestGetAllCredentialsCredStoreAndCredHelper (0.00s)
#18 64.05 file_test.go:402: assertion failed:
#18 64.05 --- expected
#18 64.05 +++ authConfigs
#18 64.05 map[string]types.AuthConfig{
#18 64.05 "credhelper.com": {Username: "cred_helper_user", Password: "cred_helper_pass"},
#18 64.05 - "credstore.com": {Username: "cred_store_user", Password: "cred_store_pass"},
#18 64.05 }
#18 64.05
It was a premature abstraction; the "nil" check for the map was redundant, making it literally a 1-liner, so just inline it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use a shorter name, which is more idiomatic, and prevents accidental shadowing of types or arguments. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah
force-pushed
the
cleanup_config
branch
from
September 26, 2025 18:09
ac9306a to
c9db2f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some more changes in this area, but need to dust it off; let's open these already as a PR 😅
cli/config/configfile: inline getConfiguredCredentialStore
It was a premature abstraction; the "nil" check for the map was redundant,
making it literally a 1-liner, so just inline it.
cli/config/configfile: use more idiomatic receiver name
Use a shorter name, which is more idiomatic, and prevents accidental
shadowing of types or arguments.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)