-
Notifications
You must be signed in to change notification settings - Fork 15
add java jakarta ee framework detection support #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bzssm
commented
Jan 9, 2026
Hi @thepetk @Jdubrick @elsony @michael-valdron kindly reqeust your review on this PR. Thanks!
Signed-off-by: bzssm <358963981@qq.com>
a8c0f8c to
7fb4963
Compare
@thepetk
thepetk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @bzssm !! Thank you for your contribution
Before I approve, I think is important to have some doc updates too! Thanks!
Signed-off-by: bzssm <358963981@qq.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bzssm
Once this PR has been reviewed and has the lgtm label, please ask for approval from thepetk. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
bzssm
commented
Jan 12, 2026
Hi @thepetk , thanks for the feedback!
I've added the documentation update in the latest commit - JakartaEE is now listed in the supported Java frameworks section of docs/public/alizer-spec.md.
Please take another look when you have a chance. Thanks!
thepetk
commented
Jan 12, 2026
@bzssm looks good in general, it only needs a rebase after we have merged another PR. Thanks!
bzssm
commented
Jan 13, 2026
@thepetk rebased. Can you please help to review again? Thanks!
thepetk
commented
Jan 13, 2026
@thepetk rebased. Can you please help to review again? Thanks!
Might need another rebase cause we had some PRs opened in parallel. Thanks!
openshift-merge-robot
commented
Jan 13, 2026
PR needs rebase.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Description of Changes
add java jakarta ee framework detection support
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.