-
Notifications
You must be signed in to change notification settings - Fork 360
Rollup tweaks for output size/perf #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This turns off `externalLiveBindings`, which generates getters for re-exported bindings. It also enables modern code generation for the modern bundles (arrow functions, object shorthand, etc).
⚠️ No Changeset found
Latest commit: cf47160
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
quantizor
commented
Apr 7, 2022
@developit this change sounds good - picking it back up eventually?
developit
commented
Jun 3, 2022
Yes - I think we are on more recent Rollup now too and can enable es2015 output.
This turns off
externalLiveBindings, which generates getters for re-exported bindings.It also enables modern code generation for the modern bundles (arrow functions, object shorthand, etc).