Feature: util hash #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

HOMODELUNA wants to merge 3 commits into cppdoc-cc:main

from HOMODELUNA:feature/util-hash-2026年01月06日

Open

Feature: util hash #92

HOMODELUNA wants to merge 3 commits into cppdoc-cc:main from HOMODELUNA:feature/util-hash-2026年01月06日

+322 −0

Conversation

@HOMODELUNA

Copy link

@HOMODELUNA HOMODELUNA commented Jan 6, 2026

migrate std::hash from https://en.cppreference.com/w/cpp/utility/hash.html

migrate std::hash<Key>::operator() from https://en.cppreference.com/w/cpp/utility/hash/operator().html

HOMODELUNA added 3 commits

January 6, 2026 16:37

@HOMODELUNA


 feat(): page: util hash

0915d58

@HOMODELUNA


 feat(std::hash): page for operator()

6f4d624

@HOMODELUNA


 fix(std::hash): use doclink

74fd43c

@vercel

Copy link

vercel bot commented Jan 6, 2026

@HOMODELUNA is attempting to deploy a commit to the microcber's projects Team on Vercel.

A member of the Team first needs to authorize it.

Lancern

Lancern requested changes

Jan 13, 2026

View reviewed changes

Copy link

Collaborator

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator() page looks good, but the std::hash page needs some major changes, including utility component enhancements.

src/content/docs/cpp/library/utility/hash.mdx

Comment on lines +16 to +46

Defined in header <CppHeader name="bitset" />.

Defined in header <CppHeader name="coroutine" />.

Defined in header <CppHeader name="chrono" />.

Defined in header <CppHeader name="filesystem" />.

Defined in header <CppHeader name="functional" />.

Defined in header <CppHeader name="memory" />.

Defined in header <CppHeader name="optional" />.

Defined in header <CppHeader name="stacktrace" />.

Defined in header <CppHeader name="string" />.

Defined in header <CppHeader name="string_view" />.

Defined in header <CppHeader name="system_error" />.

Defined in header <CppHeader name="text_encoding" />.

Defined in header <CppHeader name="thread" />.

Defined in header <CppHeader name="typeindex" />.

Defined in header <CppHeader name="variant" />.

Defined in header <CppHeader name="vector" />.

Copy link

Collaborator

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This series of header files take too much screen space on the page. I think we have to come up with a way to get around this.

src/content/docs/cpp/library/utility/hash.mdx

- If `std::hash<Key>` is not provided by the program or the user, it is disabled.

- Otherwise, `std::hash<Key>` is enabled if all following conditions are satisfied:

- All following requirements are satisfied:

- [Hash](../named_req/Hash.html "cpp/named req/Hash") (with `Key` as the function call argument type)

Copy link

Collaborator

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use <DocLink> for all cross links within cppdoc.

src/content/docs/cpp/library/utility/hash.mdx

Given a type `Key`, each specialization `std::hash<Key>` is either _enabled_ or _disabled_ :

- If `std::hash<Key>` is not provided by the program or the user, it is disabled.

Copy link

Collaborator

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave only one space between - and If.

src/content/docs/cpp/library/utility/hash.mdx

Comment on lines +102 to +105

| | |

|---|---|

|(constuctor) | <Desc kind="public member function">constructs a hash function object </Desc>|

|<DocLink dest="/cpp/library/utility/hash/operator-call"> `operator()` </DocLink> | <Desc kind="public member function">calculates the hash of the argument </Desc>|

Copy link

Collaborator

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This is not right. We need to implement a component for such content.

src/content/docs/cpp/library/utility/hash.mdx

Possible outputs:

```cpp

Copy link

Collaborator

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block does not contain C++ source code.

src/content/docs/cpp/library/utility/hash.mdx

Copy link

Collaborator

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use <DRList> for defect reports list.

Labels

None yet

2 participants

@HOMODELUNA @Lancern

Feature: util hash #92

Are you sure you want to change the base?

Feature: util hash #92

Conversation

@HOMODELUNA HOMODELUNA commented Jan 6, 2026

Uh oh!

vercel bot commented Jan 6, 2026

Uh oh!

@Lancern Lancern left a comment

Choose a reason for hiding this comment

Uh oh!

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@Lancern Lancern Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants