-
-
Notifications
You must be signed in to change notification settings - Fork 313
feat(commit): add '--allow-empty' flag to commit command #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5f6c983 to
e848587
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1217 +/- ## ========================================== + Coverage 97.33% 97.58% +0.24% ========================================== Files 42 55 +13 Lines 2104 2608 +504 ========================================== + Hits 2048 2545 +497 - Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e848587 to
5c9841e
Compare
Lee-W
commented
Aug 22, 2024
Hi, thanks for contributing! would like to know why do we want --alow-empty. I thought we already have -- --allow-empty
AdrianDC
commented
Aug 22, 2024
Coverage fixed 👍.
Lee-W, apart from regular usage, it's because the staging area checks fail :
$ cz c --allow-empty -Invalid commitizen arguments were found: `--allow-empty`. Please use -- separator for extra git args $ cz c -- --allow-empty -No files added to staging! # ======================= $ pipx uninstall commitizen; pipx install . uninstalled commitizen! ✨ 🌟 ✨ installed package commitizen 3.29.0, installed using Python 3.12.3 These apps are now globally available - cz - git-cz done! ✨ 🌟 ✨ # ======================= $ cz c --allow-empty ? Select the type of change you are committing feat: A new feature. Correlates with MINOR in SemVer ? What is the scope of this change? (class or file name): (press [enter] to skip) test ? Write a short and imperative summary of the code changes: (lower case and no period) test ? Provide additional contextual information about the code changes: (press [enter] to skip) ? Is this a BREAKING CHANGE? Correlates with MAJOR in SemVer No ? Footer. Information about Breaking Changes and reference issues that this commit closes: (press [enter] to skip) feat(test): test [master 6b9618c5] feat(test): test +Commit successful!
5c9841e to
217e255
Compare
AdrianDC
commented
Aug 25, 2024
As discussed, I redid it all into -- --allow-empty support + implemented matching tests 👍.
Tested locally with cz c, cz c -- --allow-empty and cz c -s --allow-empty
@Lee-W
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
217e255 to
556ae98
Compare
AdrianDC
commented
Nov 10, 2024
Rebased, ready to roll after 1206 👍
Lee-W
commented
Nov 16, 2024
1206 merged 🙌
Signed-off-by: Adrian DC <radian.dc@gmail.com>
556ae98 to
a442d70
Compare
AdrianDC
commented
Nov 16, 2024
👍
Description
feat(commit): add '--allow-empty' flag to commit command
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Allow to invoke cz and create a commit without any change in it
Steps to Test This Pull Request
Additional context