-
Notifications
You must be signed in to change notification settings - Fork 70
Implement slog.LogValuer #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nozo-moto
wants to merge
3
commits into
cockroachdb:master
from
nozo-moto:implment-logvalue-method-to-withstack
Open
Implement slog.LogValuer #129
nozo-moto
wants to merge
3
commits into
cockroachdb:master
from
nozo-moto:implment-logvalue-method-to-withstack
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CLA assistant check
All committers have signed the CLA.
@nozo-moto
nozo-moto
changed the title
(削除) implement LogValue method to WithStack (削除ここまで)
(追記) Implement slog.LogValuer (追記ここまで)
Sep 18, 2023
@nozo-moto
nozo-moto
force-pushed
the
implment-logvalue-method-to-withstack
branch
from
September 18, 2023 09:00
adf5647 to
556c210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
#107
This change is Reviewable
code
result
{ "time": "2023年09月18日T17:57:09.438517+09:00", "level": "INFO", "msg": "test", "error": { "message": "wrapped error 1: wrapped error 2: wrapped error 3: wrapped error 4: error root", "stacktrace": { "main.f1": { "file": "/Users/nozo/tmp/cockloaddb-slog-try/main.go", "name": "main.f1", "line": 12 }, "main.main": { "file": "/Users/nozo/tmp/cockloaddb-slog-try/main.go", "name": "main.main", "line": 33 }, "runtime.main": { "file": "/opt/homebrew/Cellar/go/1.21.1/libexec/src/runtime/proc.go", "name": "runtime.main", "line": 267 }, "runtime.goexit": { "file": "/opt/homebrew/Cellar/go/1.21.1/libexec/src/runtime/asm_arm64.s", "name": "runtime.goexit", "line": 1197 } } } }