-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Download sealights agent from 'customAgentUrl' #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download sealights agent from 'customAgentUrl' #1050
Conversation
Added support for the new parameter both from app configuration and sealights user-provided service
Searching for jar which name starts with 'sl-test-listener' in zip downloaded from customAgentUrl
Overwrite sl.enableUpgrade to false when agent is downloaded from customAgentUrl
'enable_upgrade' parameter name fix in config yml file ('auto_upgrade' was not used in sealights framework)
Modified adding system property sl.tag to contain buildpack version
CLA Signed
The committers listed above are authorized under a signed CLA.
- ✅ login: ursulaflorianczyk (1a3aa19)
@gregoryfuta
gregoryfuta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REviewed and tested internally
ursulaflorianczyk
commented
Mar 4, 2024
@pivotal-david-osullivan can I ask you for review and merging this PR?
ursulaflorianczyk
commented
Mar 18, 2024
Hello Java Buildpack Team. We would like to merge this PR to Sealights' buildpack. Could you please give me a suggestion what I should do to get review/approval and merging for this PR?
@pivotal-david-osullivan @rhardt-pivotal do you know who I should contact?
anthonydahanne
commented
Mar 28, 2024
Hello!
Sorry for the long time to get back to you - thanks for your contribution.
I have to ask you: why didn't you use the "standard" java buildpack way of getting dependencies.
In the case of sealights agent, if you look at the default configuration, you'll guess that the dependency is fetched from the latest in https://agents.sealights.co/pcf/index.yml
So if you rebuilt the java-buildpack changing
repository_root: https://agents.sealights.co/pcf
to
repository_root: https://my-own-bucket.com
and then published at https://my-own-bucket.com/index.yml a file with your own packaging of sealights, you'd be done.
Please let me know why you decided to divert from this way of providing different dependencies.
Thank you!
ursulaflorianczyk
commented
Mar 29, 2024
Hi @anthonydahanne
Thank you for your feedback!
One of our customers want to use Sealights agent downloaded from his internal URL. We would like to avoid asking him to rebuilt buildpack and providing his own /index.yml (https://his-own-bucket.com/index.yml).
pivotal-david-osullivan
commented
Apr 9, 2024
Anthony is correct, you must host the index.yml file with the <version>: <dep_uri> syntax. However, you do not need to repackage/rebuild the buildpack. You can set the operator or developer level environment variable to use the custom repository root where the new index is hosted, e.g.
JBP_CONFIG_SEALIGHTS_AGENT '{ repository_root: "<uri>" }'
Download sealights agent from 'customAgentUrl'
Some our customers want to have possibility to download specific Sealights agent from their internal URL instead of public Sealights servers. We want to provide them the easy way to configure it by adding a new parameter 'customAgentUrl'.
Sealights buildpacks should support the same parameter for the same template across all technologies that is why we add 'customAgentUrl' instead of 'custom_agent_url'.
This PR contains also: