mirrored from https://www.bouncycastle.org/repositories/bc-java
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: allows developers to provide a block pool to argon2 #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: bcgit#1646 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins
force-pushed
the
iss1646
branch
from
October 25, 2024 13:23
5b1f02e to
d6d406a
Compare
Author
shawkins
commented
Oct 25, 2024
@jill-kleiber @dghgit Rebased this. Please let me know if there is any interest in this, or if it should just be abandoned.
Collaborator
jill-kleiber
commented
Oct 28, 2024
We're currently in the process of publishing our PQC work. One that's wrapped up I'll have a look at this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1646
Provides a way for developers to reuse memory for argon2. Assumes that the implementation will call allocate / deallocate in pairs - no checking is done for multiple deallocation.
If you are open to this approach, what kind of tests would you like to see for this?
cc @ahus1 @vmuzikar