-
Notifications
You must be signed in to change notification settings - Fork 5.3k
refactor: standardize the HTML, CSS and JSP in the webapps folder. #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kkolinko
commented
Jul 5, 2020
error.html:
- Shouldn't it better be <form method="GET"?
- Options shall be closed with . The
s there are out of place and ignored. (validator.w3.org complains)
c4dfa36 to
2406b0a
Compare
jbampton
commented
Jul 6, 2020
Hey @kkolinko I removed the br tags and also closed the option tags now.
I also validated the 'error.html' by direct upload and it validates now.
0b8fdf7 to
e844277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the auto-closing ? It doesn't do any harm. I, personally, prefer the style it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In HTML5 you don't need the auto-closing.
I got the style from MDN.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but it does not do any harm either.
This change makes the diff bigger and harder to back-port to the other branches.
I prefer the XHTML style because it is easier to spot errors in the IDE/text editor without copying to W3C validator in the web.
e844277 to
6bcb3e2
Compare
6bcb3e2 to
953416e
Compare
jbampton
commented
Jul 31, 2020
error.html:
- Shouldn't it better be <form method="GET"?
- Options shall be closed with . The s there are out of place and ignored. (validator.w3.org complains)
MDN says -> Possible (case insensitive) values
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form
bb5d215 to
735e437
Compare
8c818fe to
1e7d050
Compare
Use lowercase HTML tags and attributes. Add quotes around attributes. Fix some HTML errors. Use HTML5 and CSS. Indent HTML and JSP. Remove whitespace. Remove blank lines. Standardize quotes.
1e7d050 to
192c368
Compare
ChristopherSchultz
commented
Aug 2, 2024
I'm a -1 on this change mostly because it's so large with so many changes at the same time. If this PR had been the accumulation of several commits e.g. (1) re-format whitespace everywhere with no other changes then (2) remove unnecessary auto-close elements then (3) standardize quoting, etc. then it would have been easier to review, spot things we didn't like, etc. But this is one giant change I'm unwilling to read through to decide if I like every single one of them so, no.
Uh oh!
There was an error while loading. Please reload this page.
Use lowercase HTML tags and attributes.
Add quotes around attributes.
Standardize quotes.
Fix some HTML errors.
Use HTML5 and CSS.
Remove whitespace and blank lines.
Indent HTML and JSP.