-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[parquet-thrift] remove pig usage #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dossett
commented
Dec 29, 2025
The maven verify step is failing, but I think that's ok. It's detecting the removal of functionality (i.e. a breaking change), which is the goal.
@Fokko
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dossett this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Fokko
commented
Jan 13, 2026
@dossett Can you pull in main once more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, we leave this in. For example, cascading below has been removed for ages, but is still in the list for historical reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I put that back.
@julienledem
julienledem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing this old functionality.
(personally observing a minute of silence).
6fdfdd8 to
b702170
Compare
dossett
commented
Jan 13, 2026
@dossett Can you pull in main once more?
Rebased and repushed.
Closes #3376
Removes deprecated parquet-pig functionality