-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29833: Fix dead links in README #7643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates links and reintroduces export control page to the website
Apache-HBase
commented
Jan 19, 2026
|
🎊 +1 overall
This message was automatically generated. |
@PDavid
PDavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks 👍
lfrancke
commented
Jan 19, 2026
Thanks for the quick review. I built the site locally and it looks good to me.
The content of the export control page is a 1:1 copy from what was already there.
Apache-HBase
commented
Jan 19, 2026
|
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 19, 2026
|
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 19, 2026
|
💔 -1 overall
This message was automatically generated. |
lfrancke
commented
Jan 19, 2026
Creating placeholder flownodes because failed loading originals.
ERROR: Cannot resume build because FlowNode 99 for FlowHead 1 could not be loaded. This is expected to happen when using the PERFORMANCE_OPTIMIZED durability setting and Jenkins is not shut down cleanly. Consider investigating to understand if Jenkins was not shut down cleanly or switching to the MAX_SURVIVABILITY durability setting which should prevent this issue in most cases.
I wanna say this is unrelated :)
Can this be rerun somehow?
PDavid
commented
Jan 20, 2026
Creating placeholder flownodes because failed loading originals.
ERROR: Cannot resume build because FlowNode 99 for FlowHead 1 could not be loaded. This is expected to happen when using the PERFORMANCE_OPTIMIZED durability setting and Jenkins is not shut down cleanly. Consider investigating to understand if Jenkins was not shut down cleanly or switching to the MAX_SURVIVABILITY durability setting which should prevent this issue in most cases.I wanna say this is unrelated :) Can this be rerun somehow?
Hmm, very strange. I asked about this error in the ASF infra Slack channel, let's see what they answer.
Otherwise I checked out your branch and the site builds fine locally and the website is working. 👌
lfrancke
commented
Jan 20, 2026
Thanks. The changes they suggest sound a bit "bigger" than the scope of this PR.
Let me know if you want me to make any changes or if you're fine merging as is.
PDavid
commented
Jan 20, 2026
Thanks. The changes they suggest sound a bit "bigger" than the scope of this PR. Let me know if you want me to make any changes or if you're fine merging as is.
I agree. I think you can merge this because locally it is building fine.
lfrancke
commented
Jan 20, 2026
Thanks. Will do. It's been ages since I contributed to HBase. Sorry for the newbie question. Do you usally squash and merge here?
PDavid
commented
Jan 20, 2026
Thanks. Will do. It's been ages since I contributed to HBase. Sorry for the newbie question. Do you usally squash and merge here?
Exactly. Squash and merge, adjust the commit message if needed and add the "Signed-off-by" at the end of the commit message, e.g.:
Signed-off-by: Dávid Paksy <paksyd@apache.org>
Many thanks Lars. 👍
Updates links and reintroduces export control page to the website