Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Proxmox Extension : Make settings such as storage, disk_size,... #12174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shwstppr merged 2 commits into apache:4.22 from shapeblue:proxmox-storage
Dec 3, 2025

Conversation

@abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Dec 2, 2025

Description

... iso_os_type configurable in the Proxmox extension

Doc PR: apache/cloudstack-documentation#601

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Using Template:
Screenshot 2025年12月02日 at 11 16 52 AM
Screenshot 2025年12月02日 at 11 18 58 AM

Using ISO:
Screenshot 2025年12月02日 at 11 18 40 AM
Screenshot 2025年12月02日 at 11 19 05 AM

How did you try to break this feature and the system with this change?

weizhouapache reacted with thumbs up emoji
Copy link
Member

@Asadsid121
this should fix #12163, can you test it ?

Copy link

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (21d844b) to head (3918f61).
⚠️ Report is 13 commits behind head on 4.22.

Additional details and impacted files 
@@ Coverage Diff @@
## 4.22 #12174 +/- ##
=========================================
 Coverage 17.56% 17.56% 
- Complexity 15539 15547 +8 
=========================================
 Files 5909 5910 +1 
 Lines 529097 529128 +31 
 Branches 64624 64636 +12 
=========================================
+ Hits 92913 92941 +28 
- Misses 425729 425730 +1 
- Partials 10455 10457 +2
Flag Coverage Δ
uitests 3.58% <ø> (+<0.01%) ⬆️
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Asadsid121 this should fix #12163, can you test it ?

Yes, I have tested it and its working.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

 

Co-authored-by: dahn <daan.hoogland@gmail.com>
Copy link
Collaborator Author

abh1sar commented Dec 3, 2025

@blueorangutan package

Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15898

@DaanHoogland DaanHoogland added this to the 4.22.1 milestone Dec 3, 2025
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shwstppr shwstppr merged commit 4379666 into apache:4.22 Dec 3, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the proxmox-storage branch December 3, 2025 11:35
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 11, 2025 
...che#12174)
Make storage, disk-size and os-type configurable in the Proxmox extension
Doc PR: apache/cloudstack-documentation#601
---------
Co-authored-by: dahn <daan.hoogland@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Status: Done

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

CloudStack always uses local-lvm on Proxmox instead of shared storage

AltStyle によって変換されたページ (->オリジナル) /